linux-kernel - RE: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB30345324649F1B1E05082970D20A9@DM6PR18MB3034.namprd18.prod.outlook.com>
Date:   Mon, 21 Jun 2021 05:23:10 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     SeongJae Park <sj38.park@...il.com>
CC:     Javed Hasan <jhasan@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "himanshu.madhani@...cle.com" <himanshu.madhani@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        SeongJae Park <sjpark@...zon.de>
Subject: RE: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless
 'bnx2fc_abts_cleanup()' return value assignment

Hi SeongJae,

> -----Original Message-----
> From: SeongJae Park <sj38.park@...il.com>
> Sent: Friday, June 18, 2021 10:15 PM
> To: Saurav Kashyap <skashyap@...vell.com>
> Cc: Javed Hasan <jhasan@...vell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@...vell.com>; jejb@...ux.ibm.com;
> martin.petersen@...cle.com; himanshu.madhani@...cle.com; linux-
> scsi@...r.kernel.org; linux-kernel@...r.kernel.org; SeongJae Park
> <sjpark@...zon.de>
> Subject: [EXT] [PATCH] scsi: bnx2fc: Remove meaningless
> 'bnx2fc_abts_cleanup()' return value assignment
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: SeongJae Park <sjpark@...zon.de>
> 
> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is already
> in ABTS processing") made 'bnx2fc_eh_abort()' to return 'FAILED'
> when 'io_req' is alrady in ABTS processing, regardless of the return
> value of 'bnx2fc_abts_cleanup()'.  But, it left the assignment of the
> return value of 'bnx2fc_abts_cleanup()' to 'rc', which is meaningless
> now.  This commit removes it.
> 
> This issue was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
> 
> Fixes: 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is already in ABTS
> processing")
> Signed-off-by: SeongJae Park <sjpark@...zon.de>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index ed300a279a38..f2996a9b2f63 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1213,7 +1213,7 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)
>  		 * cleanup the command and return that I/O was successfully
>  		 * aborted.
>  		 */
> -		rc = bnx2fc_abts_cleanup(io_req);
> +		bnx2fc_abts_cleanup(io_req);
>  		/* This only occurs when an task abort was requested while
> ABTS
>  		   is in progress.  Setting the IO_CLEANUP flag will skip the
>  		   RRQ process in the case when the fw generated SCSI_CMD
> cmpl

Acked-by: Saurav Kashyap <skashyap@...vell.com>

Thanks,
~Saurav 
> --
> 2.17.1