linux-kernel - Re: [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq135t9s5cy.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 22 Jun 2021 22:05:25 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     SeongJae Park <sj38.park@...il.com>
Cc:     skashyap@...vell.com, jhasan@...vell.com,
        GR-QLogic-Storage-Upstream@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, himanshu.madhani@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        SeongJae Park <sjpark@...zon.de>
Subject: Re: [PATCH] scsi: bnx2fc: Remove meaningless
 'bnx2fc_abts_cleanup()' return value assignment


SeongJae,

> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is
> already in ABTS processing") made 'bnx2fc_eh_abort()' to return
> 'FAILED' when 'io_req' is alrady in ABTS processing, regardless of the
> return value of 'bnx2fc_abts_cleanup()'.  But, it left the assignment
> of the return value of 'bnx2fc_abts_cleanup()' to 'rc', which is
> meaningless now.  This commit removes it.

Applied to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering