linux-kernel - Re: [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Jun 2021 00:10:11 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     SeongJae Park <sj38.park@...il.com>, skashyap@...vell.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        jejb@...ux.ibm.com, GR-QLogic-Storage-Upstream@...vell.com,
        linux-scsi@...r.kernel.org, SeongJae Park <sjpark@...zon.de>,
        jhasan@...vell.com, linux-kernel@...r.kernel.org,
        himanshu.madhani@...cle.com
Subject: Re: [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts_cleanup()' return value assignment

On Fri, 18 Jun 2021 16:45:14 +0000, SeongJae Park wrote:

> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is already
> in ABTS processing") made 'bnx2fc_eh_abort()' to return 'FAILED'
> when 'io_req' is alrady in ABTS processing, regardless of the return
> value of 'bnx2fc_abts_cleanup()'.  But, it left the assignment of the
> return value of 'bnx2fc_abts_cleanup()' to 'rc', which is meaningless
> now.  This commit removes it.
> 
> [...]

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts_cleanup()' return value assignment
      https://git.kernel.org/mkp/scsi/c/73b306a2bcb7

-- 
Martin K. Petersen	Oracle Linux Engineering