linux-kernel - Re: [PATCH][next] block/mq-deadline: remove redundant assignment of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dce79425-05fb-26a3-2f01-f9893de41513@acm.org>
Date:   Tue, 22 Jun 2021 14:14:44 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Colin King <colin.king@...onical.com>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] block/mq-deadline: remove redundant assignment of
 variable ret

On 6/22/21 9:17 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable ret is being assigned a value at the end of the function
> and the value is never read. The assignment is redundant and can
> be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  block/mq-deadline-main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/mq-deadline-main.c b/block/mq-deadline-main.c
> index 4815e536091f..e3091d922ba2 100644
> --- a/block/mq-deadline-main.c
> +++ b/block/mq-deadline-main.c
> @@ -639,7 +639,6 @@ static int dd_init_sched(struct request_queue *q, struct elevator_type *e)
>  	if (ret)
>  		goto free_stats;
>  
> -	ret = 0;
>  	q->elevator = eq;
>  	return 0;

Reviewed-by: Bart Van Assche <bvanassche@....org>