linux-kernel - Re: [PATCH][next] block/mq-deadline: remove redundant assignment of variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F8A7A6B5-37DB-45D8-971F-85D392618512@kernel.dk>
Date:   Tue, 22 Jun 2021 15:15:45 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Colin King <colin.king@...onical.com>, linux-block@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] block/mq-deadline: remove redundant assignment of variable ret

On Jun 22, 2021, at 3:14 PM, Bart Van Assche <bvanassche@....org> wrote:
> 
> On 6/22/21 9:17 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> Variable ret is being assigned a value at the end of the function
>> and the value is never read. The assignment is redundant and can
>> be removed.
>> 
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>> block/mq-deadline-main.c | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/block/mq-deadline-main.c b/block/mq-deadline-main.c
>> index 4815e536091f..e3091d922ba2 100644
>> --- a/block/mq-deadline-main.c
>> +++ b/block/mq-deadline-main.c
>> @@ -639,7 +639,6 @@ static int dd_init_sched(struct request_queue *q, struct elevator_type *e)
>>    if (ret)
>>        goto free_stats;
>> 
>> -    ret = 0;
>>    q->elevator = eq;
>>    return 0;
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Assuming this is fallout from the recent series, we should add a fixes tag to it. 

— 
Jens Axboe