linux-kernel - Re: [patch V3 30/66] x86/fpu: Rename fregs related copy functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNGt5ZKCjlWTA9r7@zn.tnic>
Date:   Tue, 22 Jun 2021 11:31:17 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [patch V3 30/66] x86/fpu: Rename fregs related copy functions

On Fri, Jun 18, 2021 at 04:18:53PM +0200, Thomas Gleixner wrote:
> The function names for fnsave/fnrstor operations are horribly named and
> a permanent source of confusion.
> 
> Rename:
> 	copy_fregs_to_kernel() to fnsave()

That first one is not existant.

> 	copy_kernel_to_fregs() to fnrstor()

				frstor() - no "n"

> 	copy_fregs_to_user()   to fnsave_to_user_sigframe()
> 	copy_user_to_fregs()   to fnrstor_from_user_sigframe()
> 
> so it's clear what these are doing. All these functions are really low
> level wrappers around the equaly named instructions, so mapping to the
> documentation is just natural.
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
> V3: Rename (Boris)
> ---
>  arch/x86/include/asm/fpu/internal.h |   10 +++++-----
>  arch/x86/kernel/fpu/core.c          |    2 +-
>  arch/x86/kernel/fpu/signal.c        |    6 +++---
>  3 files changed, 9 insertions(+), 9 deletions(-)

Regardless, above is just nitpicks.

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg