linux-kernel - Re: [patch V3 31/66] x86/fpu: Rename xstate copy functions which are related to UABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNGvpaSNbf1+rGew@zn.tnic>
Date:   Tue, 22 Jun 2021 11:38:45 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Kan Liang <kan.liang@...ux.intel.com>
Subject: Re: [patch V3 31/66] x86/fpu: Rename xstate copy functions which are
 related to UABI

On Fri, Jun 18, 2021 at 04:18:54PM +0200, Thomas Gleixner wrote:
> Rename them to reflect that these functions deal with user space format
> XSAVE buffers.
> 
>       copy_kernel_to_xstate() -> copy_uabi_from_kernel_to_xstate()
>       copy_user_to_xstate()   -> copy_sigframe_from_user_to_xstate()
> 
> Again a clear statement that these functions deal with user space ABI.
> 
> Suggested-by: Andy Lutomirski <luto@...nel.org>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/include/asm/fpu/xstate.h |    4 ++--
>  arch/x86/kernel/fpu/regset.c      |    2 +-
>  arch/x86/kernel/fpu/signal.c      |    2 +-
>  arch/x86/kernel/fpu/xstate.c      |    5 +++--
>  4 files changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg