linux-kernel - Re: [PATCH 1/4] MIPS: X1830: Respect cell count of common properties.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <H3S3VQ.BEEIRETNG80B@opendingux.net>
Date:   Tue, 22 Jun 2021 13:30:53 +0100
From:   Paul Cercueil <paul@...ndingux.net>
To:     周琰杰 <zhouyanjie@...yeetech.com>
Cc:     tsbogend@...ha.franken.de, robh+dt@...nel.org,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        sihui.liu@...enic.com, jun.jiang@...enic.com,
        sernia.zhou@...mail.com
Subject: Re: [PATCH 1/4] MIPS: X1830: Respect cell count of common properties.

Hi Zhou,

Le mar., juin 22 2021 at 15:37:22 +0800, 周琰杰 (Zhou Yanjie) 
<zhouyanjie@...yeetech.com> a écrit :
> If N fields of X cells should be provided, then that's what the
> devicetree should represent, instead of having one single field of
> (N * X) cells.
> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>

Acked-by: Paul Cercueil <paul@...pouillou.net>

-Paul

> ---
>  arch/mips/boot/dts/ingenic/x1830.dtsi | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsi 
> b/arch/mips/boot/dts/ingenic/x1830.dtsi
> index b21c930..59ca3a8 100644
> --- a/arch/mips/boot/dts/ingenic/x1830.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi
> @@ -97,9 +97,9 @@
> 
>  		#clock-cells = <1>;
> 
> -		clocks = <&cgu X1830_CLK_RTCLK
> -			  &cgu X1830_CLK_EXCLK
> -			  &cgu X1830_CLK_PCLK>;
> +		clocks = <&cgu X1830_CLK_RTCLK>,
> +			 <&cgu X1830_CLK_EXCLK>,
> +			 <&cgu X1830_CLK_PCLK>;
>  		clock-names = "rtc", "ext", "pclk";
> 
>  		interrupt-controller;
> @@ -274,8 +274,7 @@
> 
>  	pdma: dma-controller@...20000 {
>  		compatible = "ingenic,x1830-dma";
> -		reg = <0x13420000 0x400
> -			   0x13421000 0x40>;
> +		reg = <0x13420000 0x400>, <0x13421000 0x40>;
>  		#dma-cells = <2>;
> 
>  		interrupt-parent = <&intc>;
> --
> 2.7.4
>