linux-kernel - Re: [PATCH v2 01/17] staging: rtl8723bs: remove all 5Ghz network types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5af94a0d-af54-818f-d2ae-62f099db3dea@redhat.com>
Date:   Tue, 22 Jun 2021 14:41:36 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Fabio Aiuto <fabioaiuto83@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/17] staging: rtl8723bs: remove all 5Ghz network
 types

Hi,

On 6/22/21 2:41 PM, Hans de Goede wrote:
> Hi,
> 
> On 6/22/21 2:29 PM, Fabio Aiuto wrote:
>> remove all 5Ghz network types. rtl8723bs works on
>> 802.11bgn standards and on 2.4Ghz band.
>>
>> So remove all code related to 802.11a and 802.11ac
>> standards, which the device doesn't support.
>>
>> Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
>> ---
>>  drivers/staging/rtl8723bs/core/rtw_ap.c       | 10 +---
>>  .../staging/rtl8723bs/core/rtw_ieee80211.c    | 22 ++------
>>  drivers/staging/rtl8723bs/core/rtw_mlme.c     | 10 ----
>>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 55 -------------------
>>  .../staging/rtl8723bs/core/rtw_wlan_util.c    | 14 +----
>>  drivers/staging/rtl8723bs/hal/odm.c           | 30 ----------
>>  drivers/staging/rtl8723bs/hal/odm.h           |  3 -
>>  .../rtl8723bs/hal/odm_EdcaTurboCheck.c        |  4 +-
>>  drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  5 --
>>  drivers/staging/rtl8723bs/include/hal_phy.h   |  3 -
>>  drivers/staging/rtl8723bs/include/ieee80211.h | 22 +-------
>>  drivers/staging/rtl8723bs/include/wifi.h      |  1 -
>>  drivers/staging/rtl8723bs/os_dep/os_intfs.c   |  2 +-
>>  13 files changed, 14 insertions(+), 167 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> index 23bbdf084631..b0abadd4b4dd 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
>> @@ -343,10 +343,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
>>  
>>  	if (pcur_network->Configuration.DSConfig > 14) {
>>  		if (tx_ra_bitmap & 0xffff000)
>> -			sta_band |= WIRELESS_11_5N;
>> -
>> -		if (tx_ra_bitmap & 0xff0)
>> -			sta_band |= WIRELESS_11A;
>> +			sta_band |= WIRELESS_INVALID;
> 
> sta_band will now not be touched if tx_ra_bitmap is say 0x20, where as
> before it would be ore-d with WIRELESS_11A. Please make the or-ing with
> WIRELESS_INVALID unconditional (removing both "if (tx_ra_bitmap & 0x...)"
> checks). Also make sure to reduce the indentation level of the
> sta_band |= WIRELESS_INVALID; by 1 tab when dropping the if.

p.s.

The rest of the set looks ok to me.

Regards,

Hans