linux-kernel - [PATCH v2] workqueue: set the rescuer worker that belong to freezable wq is freezable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Jun 2021 20:42:11 +0800
From:   qiang.zhang@...driver.com
To:     tj@...nel.org, jiangshanlai@...il.com
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] workqueue: set the rescuer worker that belong to freezable wq is freezable

From: Zqiang <qiang.zhang@...driver.com>

If the rescuer worker belong to freezable wq, when this wq is
frozen, the rescuer worker also need to be frozen.

Signed-off-by: Zqiang <qiang.zhang@...driver.com>
---
 v1->v2:
 use kthread_freezable_should_stop() replaces try_to_freeze(). 

 kernel/workqueue.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 104e3ef04e33..dd7b78bdb7f1 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2476,6 +2476,9 @@ static int rescuer_thread(void *__rescuer)
 	 * doesn't participate in concurrency management.
 	 */
 	set_pf_worker(true);
+
+	if (wq->flags & WQ_FREEZABLE)
+		set_freezable();
 repeat:
 	set_current_state(TASK_IDLE);
 
@@ -2487,7 +2490,7 @@ static int rescuer_thread(void *__rescuer)
 	 * @wq->maydays processing before acting on should_stop so that the
 	 * list is always empty on exit.
 	 */
-	should_stop = kthread_should_stop();
+	should_stop = kthread_freezable_should_stop(NULL);
 
 	/* see whether any pwq is asking for help */
 	raw_spin_lock_irq(&wq_mayday_lock);
-- 
2.25.1