linux-kernel - Re: [PATCH] ARM: omap2: remove unneeded variable: "errata"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210624072838.GA1343@shell.armlinux.org.uk>
Date:   Thu, 24 Jun 2021 08:28:38 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     13145886936@....com
Cc:     tony@...mide.com, linux-arm-kernel@...ts.infradead.org,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] ARM: omap2: remove unneeded variable: "errata"

On Wed, Jun 23, 2021 at 08:27:51PM -0700, 13145886936@....com wrote:
> From: gushengxian <gushengxian@...ong.com>
> 
> Remove unneeded variable: "errata".
> 
> Signed-off-by: gushengxian <gushengxian@...ong.com>

NAK.

> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index dfc9b21ff19b..ba4a48e3d264 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -79,7 +79,6 @@ static const struct omap_dma_reg reg_map[] = {
>  
>  static unsigned configure_dma_errata(void)
>  {
> -	unsigned errata = 0;
>  
>  	/*
>  	 * Errata applicable for OMAP2430ES1.0 and all omap2420
> @@ -158,7 +157,7 @@ static unsigned configure_dma_errata(void)
>  	if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
>  		SET_DMA_ERRATA(DMA_ROMCODE_BUG);
>  
> -	return errata;
> +	return 0;

It is _not_ "unneeded" and you clearly have not compiled the resulting
code from your patch.

#define SET_DMA_ERRATA(id)              (errata |= (id))

errata is used inside the SET_DMA_ERRATA() macro. Hence, building
mach-omap2/dma.c would have failed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!