linux-kernel - Re: [PATCH 12/23] staging: rtl8188eu: remove all RT_TRACE calls from core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202106251338.jmIgIz6x-lkp@intel.com>
Date:   Fri, 25 Jun 2021 13:18:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Phillip Potter <phil@...lpotter.co.uk>, gregkh@...uxfoundation.org
Cc:     kbuild-all@...ts.01.org, Larry.Finger@...inger.net,
        dan.carpenter@...cle.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH 12/23] staging: rtl8188eu: remove all RT_TRACE calls from
 core/rtw_ieee80211.c

Hi Phillip,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Phillip-Potter/staging-rtl8188eu-remove-include-rtw_debug-h/20210625-081023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git fcc84fe12fd8271ea0d94cbac4ae02f9162f56fd
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3cd6b5774f6ae082885e4c6c1dce8aeab74df4d6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Phillip-Potter/staging-rtl8188eu-remove-include-rtw_debug-h/20210625-081023
        git checkout 3cd6b5774f6ae082885e4c6c1dce8aeab74df4d6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8188eu/core/rtw_ieee80211.c: In function 'rtw_get_sec_ie':
>> drivers/staging/rtl8188eu/core/rtw_ieee80211.c:468:15: warning: variable 'sec_idx' set but not used [-Wunused-but-set-variable]
     468 |  u8 authmode, sec_idx;
         |               ^~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/sec_idx +468 drivers/staging/rtl8188eu/core/rtw_ieee80211.c

   465	
   466	void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie, u16 *wpa_len)
   467	{
 > 468		u8 authmode, sec_idx;
   469		u8 wpa_oui[4] = {0x0, 0x50, 0xf2, 0x01};
   470		uint cnt;
   471	
   472		/* Search required WPA or WPA2 IE and copy to sec_ie[] */
   473	
   474		cnt = _TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_;
   475	
   476		sec_idx = 0;
   477	
   478		while (cnt < in_len) {
   479			authmode = in_ie[cnt];
   480	
   481			if ((authmode == WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt + 2], &wpa_oui[0], 4))) {
   482				if (wpa_ie)
   483					memcpy(wpa_ie, &in_ie[cnt], in_ie[cnt + 1] + 2);
   484	
   485				*wpa_len = in_ie[cnt + 1] + 2;
   486				cnt += in_ie[cnt + 1] + 2;  /* get next */
   487			} else {
   488				if (authmode == WLAN_EID_RSN) {
   489					if (rsn_ie)
   490						memcpy(rsn_ie, &in_ie[cnt], in_ie[cnt + 1] + 2);
   491	
   492					*rsn_len = in_ie[cnt + 1] + 2;
   493					cnt += in_ie[cnt + 1] + 2;  /* get next */
   494				} else {
   495					cnt += in_ie[cnt + 1] + 2;   /* get next */
   496				}
   497			}
   498		}
   499	}
   500	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54837 bytes)