linux-kernel - Re: [PATCH 00/23] staging: rtl8188eu: remove include/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210625124356.GJ2040@kadam>
Date:   Fri, 25 Jun 2021 15:43:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH 00/23] staging: rtl8188eu: remove include/rtw_debug.h

Looks good.

I feel like the kbuild warnings could be addressed in later patches.

It seems as if some of the error handling in this driver is "pretend to
print an error message (but it's actually dead code)".  Which is
probably not the correct way to handle errors...  :/  But that's not
something introduced by this patch.

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter