linux-kernel - [PATCH] certs: Redirect openssl error message to null device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210625122902.4058783-1-stefanb@linux.vnet.ibm.com>
Date:   Fri, 25 Jun 2021 08:29:02 -0400
From:   Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:     keyrings@...r.kernel.org, jarkko@...nel.org
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, zohar@...ux.ibm.com,
        nayna@...ux.ibm.com, jeyu@...nel.org, dhowells@...hat.com,
        dwmw2@...radead.org, Stefan Berger <stefanb@...ux.ibm.com>,
        kernel test robot <lkp@...el.com>
Subject: [PATCH] certs: Redirect openssl error message to null device

From: Stefan Berger <stefanb@...ux.ibm.com>

Address the following issue detected by the kernel test robot when
there's no certificate file at the time when checking for the type
of key in the cert:

Can't open certs/signing_key.pem for reading, No such file or directory

The simplest solution is to redirect openssl's stderr output to /dev/null.

Fixes: 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")
Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
Reported-by: kernel test robot <lkp@...el.com>
---
 certs/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/Makefile b/certs/Makefile
index 72758684d254..e7ae3bd3be4a 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -65,7 +65,7 @@ openssl_available       = $(shell openssl help 2>/dev/null && echo yes)
 ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem")
 
 ifeq ($(openssl_available),yes)
-X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)
+X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null)
 
 $(if $(findstring rsaEncryption,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY)))
 endif
-- 
2.31.1