linux-kernel - Re: [PATCH] certs: Redirect openssl error message to null device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e925935-529e-49c9-e499-3eac43bddb66@linux.ibm.com>
Date:   Fri, 25 Jun 2021 08:32:37 -0400
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        keyrings@...r.kernel.org, jarkko@...nel.org
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, zohar@...ux.ibm.com,
        nayna@...ux.ibm.com, jeyu@...nel.org, dhowells@...hat.com,
        dwmw2@...radead.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] certs: Redirect openssl error message to null device

On 6/25/21 8:29 AM, Stefan Berger wrote:

> From: Stefan Berger <stefanb@...ux.ibm.com>
>
> Address the following issue detected by the kernel test robot when
> there's no certificate file at the time when checking for the type
> of key in the cert:
>
> Can't open certs/signing_key.pem for reading, No such file or directory
>
> The simplest solution is to redirect openssl's stderr output to /dev/null.
>
> Fixes: 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> Reported-by: kernel test robot <lkp@...el.com>


Jarkko,

can you please squash this patch into the one it fixes. Unfortunately 
when rebasing you will have to fix the subsequent patch from this merge 
error

ifeq ($(openssl_available),yes)
<<<<<<< HEAD
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
=======
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text)
endif
 >>>>>>> 87e968848116 (certs: Add support for using elliptic curve keys 
for signing modules)

to this:


ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 
2>/dev/null)
endif

Thanks.

    Stefan