linux-kernel - Re: [PATCH] tools/testing/nvdimm: NULL check before vfree() is not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210625173710.GA14491@alison-desk.jf.intel.com>
Date:   Fri, 25 Jun 2021 10:37:10 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     13145886936@....com
Cc:     dan.j.williams@...el.com, vishal.l.verma@...el.com,
        dave.jiang@...el.com, ira.weiny@...el.com, nvdimm@...ts.linux.dev,
        linux-kernel@...r.kernel.org, gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] tools/testing/nvdimm: NULL check before vfree() is not
 needed

Hi Gushengxian,

The code change looks good.  A couple of cleanups noted below...
(same feedback on next patch too)

On Fri, Jun 25, 2021 at 12:27:00AM -0700, 13145886936@....com wrote:
> From: gushengxian <gushengxian@...ong.com>
> 
> NULL check before vfree() is not needed.

The commit message needs to say what was done, not the why.
Example: "[PATCH] tools/testing/nvdimm: Remove NULL test before vfree"

Then, the commit log explains why this should be done.
Example: "This NULL test is redundant since vfree() checks for NULL."

Coccinelle reports this vfree() case. If you did use Coccinelle
to find it, please mention that in the commit log.
Example: "Reported by Coccinelle."

> 
> Signed-off-by: gushengxian <gushengxian@...ong.com>

The email addresses don't match (13145886936@....com,
gushengxian@...ong.com) and it's not clear that you are using your
full, legal name in the 'name line.

You can find more info on this feedback at:
https://kernelnewbies.org/FirstKernelPatch
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Alison

> ---
>  tools/testing/nvdimm/test/nfit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 54f367cbadae..cb86f0cbb11c 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -1641,8 +1641,8 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
>   err:
>  	if (*dma && size >= DIMM_SIZE)
>  		gen_pool_free(nfit_pool, *dma, size);
> -	if (buf)
> -		vfree(buf);
> +
> +	vfree(buf);
>  	kfree(nfit_res);
>  	return NULL;
>  }
> -- 
> 2.25.1
> 
>