linux-kernel - Re: [PATCH 13/14] d_path: prepend_path() is unlikely to return non-zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNYZTIP+anazsz/U@zeniv-ca.linux.org.uk>
Date:   Fri, 25 Jun 2021 17:58:36 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Justin He <Justin.He@....com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Jonathan Corbet <corbet@....net>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ira Weiny <ira.weiny@...el.com>,
        Eric Biggers <ebiggers@...gle.com>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 13/14] d_path: prepend_path() is unlikely to return
 non-zero

On Fri, Jun 25, 2021 at 08:00:49AM +0000, Justin He wrote:
> --- a/fs/d_path.c
> +++ b/fs/d_path.c
> @@ -210,6 +210,7 @@ static int prepend_path(const struct path *path,
>         b = *p;
>         read_seqbegin_or_lock(&rename_lock, &seq);
>         error = __prepend_path(path->dentry, real_mount(path->mnt), root, &b);
> +       printk("prepend=%d",error);
>         if (!(seq & 1))
>                 rcu_read_unlock();
>         if (need_seqretry(&rename_lock, seq)) {
> 
> Then the result seems a little different:
> root@...os-ampere-02:~# dmesg |grep prepend=1 |wc -l
> 7417
> root@...os-ampere-02:~# dmesg |grep prepend=0 |wc -l
> 772
> 
> The kernel is 5.13.0-rc2+ + this series + my '%pD' series
> 
> Any thoughts?

On which loads?  1 here is "mount/dentry pair is in somebody
else's namespace or outside of the subtree we are chrooted
into".  IOW, what's calling d_path() on your setup?