linux-kernel - Re: [PATCH] usb: cdns3: Fixed incorrect gadget state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210626085655.GA13671@Peter>
Date:   Sat, 26 Jun 2021 16:56:55 +0800
From:   Peter Chen <peter.chen@...nel.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     rogerq@...nel.org, a-govindraju@...com, gregkh@...uxfoundation.org,
        felipe.balbi@...ux.intel.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, kishon@...com, kurahul@...ence.com,
        sparmar@...ence.com, stable@...r.kernel.org
Subject: Re: [PATCH] usb: cdns3: Fixed incorrect gadget state

On 21-06-23 09:02:47, Pawel Laszczak wrote:
> From: Pawel Laszczak <pawell@...ence.com>
> 
> For delayed status phase, the usb_gadget->state was set
> to USB_STATE_ADDRESS and it has never been updated to
> USB_STATE_CONFIGURED.
> Patch updates the gadget state to correct USB_STATE_CONFIGURED.
> As a result of this bug the controller was not able to enter to
> Test Mode while using MSC function.

Pawel, would you please describe more about this issue? I remember the cdns3
controller at i.mx series SoC could enter test mode by using current
code.

Peter

> 
> Cc: <stable@...r.kernel.org>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> ---
>  drivers/usb/cdns3/cdns3-ep0.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0.c
> index 9a17802275d5..ec5bfd8944c3 100644
> --- a/drivers/usb/cdns3/cdns3-ep0.c
> +++ b/drivers/usb/cdns3/cdns3-ep0.c
> @@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep,
>  		request->actual = 0;
>  		priv_dev->status_completion_no_call = true;
>  		priv_dev->pending_status_request = request;
> +		usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED);
>  		spin_unlock_irqrestore(&priv_dev->lock, flags);
>  
>  		/*
> -- 
> 2.25.1
> 

-- 

Thanks,
Peter Chen