linux-kernel - Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210626092113.GZ22278@shell.armlinux.org.uk>
Date:   Sat, 26 Jun 2021 10:21:13 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Jinchao Wang <wjc@...rlc.com>
Cc:     guillaume.tucker@...labora.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned

On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote:
>   * By default, we write directly to secure registers.  Platforms must
>   * override this if they are running non-secure.
>   */
> -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg)
> +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg)

... and then I'll get another patch because this now goes over 80
characters. No thanks.

There is nothing inherently wrong with "unsigned" - it's always been
legal C, and I'd prefer to keep the code as-is under arch/arm in
regard of this.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!