linux-kernel - Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210627120004.u4pn3stgcny2zl4i@liuwe-devbox-debian-v2>
Date:   Sun, 27 Jun 2021 12:00:04 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Nuno Das Neves <nunodasneves@...ux.microsoft.com>
Cc:     linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mikelley@...rosoft.com,
        viremana@...ux.microsoft.com, sunilmut@...rosoft.com,
        wei.liu@...nel.org, vkuznets@...hat.com, ligrassi@...rosoft.com,
        kys@...rosoft.com
Subject: Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)

On Fri, May 28, 2021 at 03:43:23PM -0700, Nuno Das Neves wrote:
[...]
> +
> +static int
> +__init mshv_init(void)
> +{
> +	int ret;

Please check if Linux is running on Microsoft Hypervisor here. If not,
this module should not be loaded.

Something like:

       if (!hv_is_hyperv_initialized())
               return -ENODEV;

Wei.