linux-kernel - Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jul 2021 08:41:03 -0700
From:   Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To:     Wei Liu <wei.liu@...nel.org>
Cc:     linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mikelley@...rosoft.com,
        viremana@...ux.microsoft.com, sunilmut@...rosoft.com,
        vkuznets@...hat.com, ligrassi@...rosoft.com, kys@...rosoft.com
Subject: Re: [PATCH 03/19] drivers/hv: minimal mshv module (/dev/mshv/)


On 6/27/2021 5:00 AM, Wei Liu wrote:
> On Fri, May 28, 2021 at 03:43:23PM -0700, Nuno Das Neves wrote:
> [...]
>> +
>> +static int
>> +__init mshv_init(void)
>> +{
>> +	int ret;
> 
> Please check if Linux is running on Microsoft Hypervisor here. If not,
> this module should not be loaded.
> 
> Something like:
> 
>        if (!hv_is_hyperv_initialized())
>                return -ENODEV;

Good point - will do.

> 
> Wei.
>