linux-kernel - Re: [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <162484042495.3259633.4035444135672420533@swboyd.mtv.corp.google.com>
Date:   Sun, 27 Jun 2021 17:33:44 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jian Xin <xinjian34324@....com>, dinguyen@...nel.org,
        mturquette@...libre.com
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jian Xin <xinjian@...ong.com>
Subject: Re: [PATCH] clk: socfpga: clk-pll: Remove unused variable 'rc'

Quoting Jian Xin (2021-06-09 00:37:42)
> From: Jian Xin <xinjian@...ong.com>
> 
> Fix the following build warning:
>   drivers/clk/socfpga/clk-pll.c: In function ‘__socfpga_pll_init’:
>   drivers/clk/socfpga/clk-pll.c:83:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Jian Xin <xinjian@...ong.com>
> ---

Applied to clk-next but it would be better to check the return value and
fail properly.