linux-kernel - Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b738198-c77e-e35e-2bc8-f709d8ec937f@linux.intel.com>
Date:   Mon, 28 Jun 2021 11:11:26 +0300
From:   "Bayduraev, Alexey V" <alexey.v.bayduraev@...ux.intel.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Alexei Budankov <abudankov@...wei.com>,
        Riccardo Mancini <rickyman7@...il.com>
Subject: Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic
 perf record operation

Hello,

On 27.06.2021 3:46, Namhyung Kim wrote:
> Hello,
> 
> On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev
> <alexey.v.bayduraev@...ux.intel.com> wrote:
>>
>> Changes in v7:
>> - fixed possible crash after out_free_threads label
>> - added missing pthread_attr_destroy() call
>> - added check of correctness of user masks
>> - fixed zsts_data finalization
>>
[SNIP]
> Thanks for your work, mostly looks good now.
> 
> I have a question, where are the synthesized records saved?
> Is it the data.0 file?

Thanks for the review.

As I understand the synthesized records (as well as other user-space
records) are saved to perf.data/data, kernel records are saved to
perf.data/data.<CPU>

Regards,
Alexey

> 
> Thanks,
> Namhyung
> 
> 
>>
>>  tools/include/linux/bitmap.h             |   11 +
>>  tools/lib/api/fd/array.c                 |   17 +
>>  tools/lib/api/fd/array.h                 |    1 +
>>  tools/lib/bitmap.c                       |   14 +
>>  tools/perf/Documentation/perf-record.txt |   30 +
>>  tools/perf/builtin-inject.c              |    3 +-
>>  tools/perf/builtin-record.c              | 1094 ++++++++++++++++++++--
>>  tools/perf/util/evlist.c                 |   16 +
>>  tools/perf/util/evlist.h                 |    1 +
>>  tools/perf/util/mmap.c                   |    6 +
>>  tools/perf/util/mmap.h                   |    6 +
>>  tools/perf/util/ordered-events.h         |    1 +
>>  tools/perf/util/record.h                 |    2 +
>>  tools/perf/util/session.c                |  500 +++++++---
>>  tools/perf/util/session.h                |    5 +
>>  tools/perf/util/tool.h                   |    3 +-
>>  16 files changed, 1508 insertions(+), 202 deletions(-)
>>
>> --
>> 2.19.0
>>