linux-kernel - Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7ci4M5hNTXm4iqj91=DXnC=qUpeWMXAHsFtgBq=J=VTqKw@mail.gmail.com>
Date:   Tue, 29 Jun 2021 23:09:31 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     "Bayduraev, Alexey V" <alexey.v.bayduraev@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Alexei Budankov <abudankov@...wei.com>,
        Riccardo Mancini <rickyman7@...il.com>
Subject: Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic
 perf record operation

On Mon, Jun 28, 2021 at 1:11 AM Bayduraev, Alexey V
<alexey.v.bayduraev@...ux.intel.com> wrote:
>
> Hello,
>
> On 27.06.2021 3:46, Namhyung Kim wrote:
> > Hello,
> >
> > On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev
> > <alexey.v.bayduraev@...ux.intel.com> wrote:
> >>
> >> Changes in v7:
> >> - fixed possible crash after out_free_threads label
> >> - added missing pthread_attr_destroy() call
> >> - added check of correctness of user masks
> >> - fixed zsts_data finalization
> >>
> [SNIP]
> > Thanks for your work, mostly looks good now.
> >
> > I have a question, where are the synthesized records saved?
> > Is it the data.0 file?
>
> Thanks for the review.
>
> As I understand the synthesized records (as well as other user-space
> records) are saved to perf.data/data, kernel records are saved to
> perf.data/data.<CPU>

Ah, ok.  I saw you added a reader for the file in patch 20/20.
Maybe we can save all tracking records (task/mmap) there
in the future.

For the patchset,
  Acked-by: Namhyung Kim <namhyung@...il.com>

Thanks,
Namhyung