linux-kernel - Re: [PATCH v2 03/24] objtool: Handle __sanitize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNmRXdFCGfoXw2zG@hirez.programming.kicks-ass.net>
Date:   Mon, 28 Jun 2021 11:07:41 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Marco Elver <elver@...gle.com>
Cc:     jpoimboe@...hat.com, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, joro@...tes.org,
        boris.ostrovsky@...cle.com, jgross@...e.com, x86@...nel.org,
        mbenes@...e.com, rostedt@...dmis.org, dvyukov@...gle.com
Subject: Re: [PATCH v2 03/24] objtool: Handle __sanitize_cov*() tail calls

On Fri, Jun 25, 2021 at 01:05:39PM +0200, Marco Elver wrote:
> On Thu, Jun 24, 2021 at 11:41AM +0200, Peter Zijlstra wrote:
> > Turns out the compilers also generate tail calls to __sanitize_cov*(),
> > make sure to also patch those out in noinstr code.
> > 
> > Fixes: 0f1441b44e82 ("objtool: Fix noinstr vs KCOV")
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> 
> Acked-by: Marco Elver <elver@...gle.com>
> 
> Thanks! More reason to not even try to do the same for other
> architectures, and the compiler needing the attribute...

Agreed!