linux-kernel - Re: [PATCH] leds: remove ide-disk trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net>
Date:   Tue, 29 Jun 2021 12:47:27 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Corentin Labbe <clabbe@...libre.com>, pavel@....cz,
        robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: remove ide-disk trigger

On 28.06.21 21:17, Corentin Labbe wrote:

> diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c
> index 0741910785bb..38a5c21c0466 100644
> --- a/drivers/leds/trigger/ledtrig-disk.c
> +++ b/drivers/leds/trigger/ledtrig-disk.c
> @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void)
>   	led_trigger_register_simple("disk-activity", &ledtrig_disk);
>   	led_trigger_register_simple("disk-read", &ledtrig_disk_read);
>   	led_trigger_register_simple("disk-write", &ledtrig_disk_write);
> -	led_trigger_register_simple("ide-disk", &ledtrig_ide);
>   
>   	return 0;
>   }

Shouldn't this line also be removed ?

   DEFINE_LED_TRIGGER(ledtrig_ide);


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287