linux-kernel - Re: [PATCH] leds: remove ide-disk trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YONsz9dG08YZOLg6@Red>
Date:   Mon, 5 Jul 2021 22:34:23 +0200
From:   LABBE Corentin <clabbe@...libre.com>
To:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
Cc:     pavel@....cz, robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: remove ide-disk trigger

Le Tue, Jun 29, 2021 at 12:47:27PM +0200, Enrico Weigelt, metux IT consult a écrit :
> On 28.06.21 21:17, Corentin Labbe wrote:
> 
> > diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c
> > index 0741910785bb..38a5c21c0466 100644
> > --- a/drivers/leds/trigger/ledtrig-disk.c
> > +++ b/drivers/leds/trigger/ledtrig-disk.c
> > @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void)
> >   	led_trigger_register_simple("disk-activity", &ledtrig_disk);
> >   	led_trigger_register_simple("disk-read", &ledtrig_disk_read);
> >   	led_trigger_register_simple("disk-write", &ledtrig_disk_write);
> > -	led_trigger_register_simple("ide-disk", &ledtrig_ide);
> >   
> >   	return 0;
> >   }
> 
> Shouldn't this line also be removed ?
> 
>    DEFINE_LED_TRIGGER(ledtrig_ide);
> 

Yes, I will send a v2.
Thanks