linux-kernel - Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock delay definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jun 2021 15:58:23 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Harini Katakam <harini.katakam@...inx.com>
Cc:     robh+dt@...nel.org, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, kuba@...nel.org, steen.hegelund@...rochip.com,
        bjarni.jonasson@...rochip.com, ioana.ciornei@....com,
        likaige@...ngson.cn, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        harinikatakamlinux@...il.com, michal.simek@...inx.com,
        radhey.shyam.pandey@...inx.com
Subject: Re: [PATCH 1/3] include: dt-bindings: Add mscc-vsc8531 RGMII clock
 delay definitions

On Tue, Jun 29, 2021 at 03:10:36PM +0530, Harini Katakam wrote:
> Add RGMII clock delay definitions in mscc-phy-vsc8531 header.
> 
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>  include/dt-bindings/net/mscc-phy-vsc8531.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/dt-bindings/net/mscc-phy-vsc8531.h b/include/dt-bindings/net/mscc-phy-vsc8531.h
> index 9eb2ec2b2ea9..242eb4c7ede9 100644
> --- a/include/dt-bindings/net/mscc-phy-vsc8531.h
> +++ b/include/dt-bindings/net/mscc-phy-vsc8531.h
> @@ -28,4 +28,13 @@
>  #define VSC8531_FORCE_LED_OFF           14
>  #define VSC8531_FORCE_LED_ON            15
>  
> +#define VSC8531_RGMII_CLK_DELAY_0_2_NS	0
> +#define VSC8531_RGMII_CLK_DELAY_0_8_NS	1
> +#define VSC8531_RGMII_CLK_DELAY_1_1_NS	2
> +#define VSC8531_RGMII_CLK_DELAY_1_7_NS	3
> +#define VSC8531_RGMII_CLK_DELAY_2_0_NS	4
> +#define VSC8531_RGMII_CLK_DELAY_2_3_NS	5
> +#define VSC8531_RGMII_CLK_DELAY_2_6_NS	6
> +#define VSC8531_RGMII_CLK_DELAY_3_4_NS	7

Using defines like this is no longer used. Please specify the delay in
pS and convert to a register value within the driver.

   Andrew