linux-kernel - Re: [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNspC065DnVpzADe@lunn.ch>
Date:   Tue, 29 Jun 2021 16:07:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Harini Katakam <harini.katakam@...inx.com>
Cc:     robh+dt@...nel.org, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, kuba@...nel.org, steen.hegelund@...rochip.com,
        bjarni.jonasson@...rochip.com, ioana.ciornei@....com,
        likaige@...ngson.cn, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        harinikatakamlinux@...il.com, michal.simek@...inx.com,
        radhey.shyam.pandey@...inx.com
Subject: Re: [PATCH 2/3] dt-bindings: mscc: Add RGMII RX and TX delay tuning

On Tue, Jun 29, 2021 at 03:10:37PM +0530, Harini Katakam wrote:
> Add optional properties to tune RGMII RX and TX delay.
> 
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>  .../devicetree/bindings/net/mscc-phy-vsc8531.txt         | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 87a27d775d48..e201d24d8e27 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -33,7 +33,14 @@ Optional properties:
>  			  VSC8531_DUPLEX_COLLISION (8).
>  - load-save-gpios	: GPIO used for the load/save operation of the PTP
>  			  hardware clock (PHC).
> -
> +- vsc8531,rx-delay	: RGMII RX delay. Allowed values are defined in
> +			  "include/dt-bindings/net/mscc-phy-vsc8531.h".
> +			  Default value, set by the driver is
> +			  VSC8531_RGMII_CLK_DELAY_2_0_NS.
> +- vsc8531,tx-delay	: RGMII TX delay. Allowed values are defined in
> +			  "include/dt-bindings/net/mscc-phy-vsc8531.h".
> +			  Default value, set by the driver is
> +			  VSC8531_RGMII_CLK_DELAY_2_0_NS.

The default values need better explanation. So you are saying they are
only used when 'rgmii' is not used. And they replace the default 2ns
delay, they don't add to the default 2ns delay.

       Andrew