linux-kernel - Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXv+5GE_ksZseTWKLpwrZvQkLx64TvATYw_dGKzOCU1Jd0hKQ@mail.gmail.com>
Date:   Wed, 30 Jun 2021 15:29:16 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        zhiyong.tao@...iatek.com, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for
 i2c pins

On Wed, Jun 30, 2021 at 3:27 PM Chen-Yu Tsai <wenst@...omium.org> wrote:
>
> On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <hsinyi@...omium.org> wrote:
> >
> > mt8183 i2c pins don't support PUPD register, so change to use generic
> > pin configs instead of let it fail and fallback.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
>
> Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>

You might also want:

Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")

> On a side note, the `mediatek,pull-up-adv` property probably should be
> merged into `bias-pull-up` with an argument.