linux-kernel - Re: [PATCH] ACPI / amba: Fix resource name in /proc/iomem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j3oCqW-D-Z3jRP9w8uETsYjxB+=Tsm3-B5FNOYR1QgeQ@mail.gmail.com>
Date:   Wed, 30 Jun 2021 20:02:11 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Liguang Zhang <zhangliguang@...ux.alibaba.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI / amba: Fix resource name in /proc/iomem

On Tue, Jun 29, 2021 at 1:28 PM Liguang Zhang
<zhangliguang@...ux.alibaba.com> wrote:
>
> In function amba_handler_attach(), dev->res.name is initialized by
> amba_device_alloc. But when address_found is false, dev->res.name is
> assigned to null value, which leads to wrong resource name display in
> /proc/iomem, "<BAD>" is seen for those resources.
>
> Signed-off-by: Liguang Zhang <zhangliguang@...ux.alibaba.com>
> ---
>  drivers/acpi/acpi_amba.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c
> index 49b781a9cd97..ab8a4e0191b1 100644
> --- a/drivers/acpi/acpi_amba.c
> +++ b/drivers/acpi/acpi_amba.c
> @@ -76,6 +76,7 @@ static int amba_handler_attach(struct acpi_device *adev,
>                 case IORESOURCE_MEM:
>                         if (!address_found) {
>                                 dev->res = *rentry->res;
> +                               dev->res.name = dev_name(&dev->dev);
>                                 address_found = true;
>                         }
>                         break;
> --

Applied as 5.14-rc1 material, thanks!