linux-kernel - Re: [PATCH -next v2] riscv: Enable KFENCE for riscv64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNM4nJBu_7HyEGdb5x-me25duwH_kLU01XBZANEBTO3EhQ@mail.gmail.com>
Date:   Thu, 1 Jul 2021 08:26:21 +0200
From:   Marco Elver <elver@...gle.com>
To:     Palmer Dabbelt <palmerdabbelt@...gle.com>
Cc:     liushixin2@...wei.com, Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, glider@...gle.com, dvyukov@...gle.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kasan-dev@...glegroups.com
Subject: Re: [PATCH -next v2] riscv: Enable KFENCE for riscv64

On Thu, 1 Jul 2021 at 04:38, 'Palmer Dabbelt' via kasan-dev
<kasan-dev@...glegroups.com> wrote:
> On Wed, 16 Jun 2021 02:11:53 PDT (-0700), elver@...gle.com wrote:
> > On Tue, 15 Jun 2021 at 04:35, Liu Shixin <liushixin2@...wei.com> wrote:
> >> Add architecture specific implementation details for KFENCE and enable
> >> KFENCE for the riscv64 architecture. In particular, this implements the
> >> required interface in <asm/kfence.h>.
> >>
> >> KFENCE requires that attributes for pages from its memory pool can
> >> individually be set. Therefore, force the kfence pool to be mapped at
> >> page granularity.
> >>
> >> Testing this patch using the testcases in kfence_test.c and all passed.
> >>
> >> Signed-off-by: Liu Shixin <liushixin2@...wei.com>
> >> Acked-by: Marco Elver <elver@...gle.com>
> >> Reviewed-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> >
> > I can't see this in -next yet. It would be nice if riscv64 could get
> > KFENCE support.
>
> Thanks, this is on for-next.  I'm just doing a boot test with
> CONFIG_KFENCE=y (and whatever that turns on for defconfig), let me know
> if there's anything more interesting to test on the KFENCE side of
> things.

To test if everything still works, CONFIG_KFENCE_KUNIT_TEST=y
(requires CONFIG_KUNIT=y) will run the KFENCE test suite on boot.

Thanks,
-- Marco