linux-kernel - Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org>
Date:   Thu, 1 Jul 2021 11:31:09 +0200
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Dennis Gilmore <dgilmore@...hat.com>,
        linux-rockchip@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

Hello,

On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system.

I wonder if this should better be fixed in u-boot then?!

> All other rk3399 systems use this format

This is true for the dwc nodes, however for the usb2 nodes there are 
several that use this idiom (and even repeat the label name), see for 
example the &u2phy0 node in 
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .

In my eyes it's a bit ugly to have the two nodes as separate entities 
and on the same indentation level in the machine dts given that one is 
the parent of the other and enabling USB needs both status settings.

Best regards
Uwe

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (489 bytes)