linux-kernel - Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jul 2021 10:32:33 +0100
From:   Robin Murphy <robin.murphy@....com>
To:     Dennis Gilmore <dgilmore@...hat.com>,
        linux-rockchip@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

On 2021-07-01 01:40, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system. All other rk3399 systems use this format

This doesn't make much sense - the usbdrd_dwc3_1 label is defined in 
rk3399.dtsi either way, and the compiled DTBs before and after are 
identical :/

If U-Boot is doing something funny with labels and symbols to give 
itself some kind of fragile dependency, that probably wants to be fixed 
in U-Boot.

Robin.

> Signed-off-by: Dennis Gilmore <dgilmore@...hat.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 738cfd21df3e..aeedf098f67c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -490,9 +490,9 @@ &uart2 {
>   
>   &usbdrd3_1 {
>   	status = "okay";
> +};
>   
> -	usb@...00000 {
> -		dr_mode = "host";
> -		status = "okay";
> -	};
> +&usbdrd_dwc3_1 {
> +	dr_mode = "host";
> +	status = "okay";
>   };
>