linux-kernel - Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1d39dfbe1398192ef1181fc98d6b7e6bedeb649.camel@puri.sm>
Date:   Fri, 02 Jul 2021 10:04:35 +0200
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     bvanassche@....org, jejb@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-scsi@...r.kernel.org, martin.petersen@...cle.com,
        kernel@...i.sm, stern@...land.harvard.edu
Subject: Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for
 BLIST_MEDIA_CHANGE devices in runtime_resume()

Am Donnerstag, dem 01.07.2021 um 15:49 +0100 schrieb Christoph Hellwig:
> On Wed, Jun 30, 2021 at 10:44:52AM +0200, Martin Kepplinger wrote:
> > +       struct scsi_disk *sdkp = dev_get_drvdata(dev);
> > +       struct scsi_device *sdp = sdkp->device;
> > +       int timeout, res;
> > +
> > +       timeout = sdp->request_queue->rq_timeout *
> > SD_FLUSH_TIMEOUT_MULTIPLIER;
> 
> Is REQUEST SENSE reqlly a so slow operation on these devices that
> we need to override the timeout?

using SD_TIMEOUT works equally fine for me. Is that what you'd rather
like to see?

Bart, is SD_TIMEOUT equally ok for you? If so, I'll resend with your
reviewed-by.

thank you for reviewing!

                            martin