linux-kernel - Re: [GIT PULL] cgroup changes for v5.14-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YN5egtsVvp3xIqCl@mtj.duckdns.org>
Date:   Thu, 1 Jul 2021 14:32:02 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Cgroups <cgroups@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] cgroup changes for v5.14-rc1

Hello,

On Thu, Jul 01, 2021 at 05:25:59PM -0700, Linus Torvalds wrote:
> On Thu, Jul 1, 2021 at 1:55 PM Tejun Heo <tj@...nel.org> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-5.14
> 
> I've pulled it, but let me vent about this history a bit.
> 
> Look at commit c2a11971549b ("Merge branch 'for-5.13-fixes' into for-5.14").
> 
> Now tell me how that commit explains why it exists.
> 
> Merge commits need commit messages too.
> 
> In particular, they need commit messages that *explain* why they exist
> in the first place, not just a one-liner that says what it does (and
> does so badly at that).

for-5.13-fixes had comment updates across the file and I pulled them into
for-5.14 to avoid trivial context conflicts down the line. Yeah, I should
have commented on the rationale. Will add explanations from now on.

Thanks.

-- 
tejun