linux-kernel - Re: [PATCH v13] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf0_8+KW_cp2g0V1miMx1cegBdjLzBjTbtpmcmdCHQJxA@mail.gmail.com>
Date:   Mon, 5 Jul 2021 11:45:23 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Jie Deng <jie.deng@...el.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...nel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        yu1.wang@...el.com, shuo.a.liu@...el.com, conghui.chen@...el.com,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v13] i2c: virtio: add a virtio i2c frontend driver

On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 05-07-21, 14:53, Jie Deng wrote:

> > +#include <linux/types.h>
> > +#include <linux/const.h>
>
> Both of these need to be the uapi headers as Andy said earlier

They are already since this header _is_ UAPI, what you are suggesting
is gonna not work, although it's correct for in-kernel users of UAPI
headers.

>  and they better
> be in alphabetical order.

I prefer that as well.

> #include <uapi/linux/const.h>
> #include <uapi/linux/types.h>

-- 
With Best Regards,
Andy Shevchenko