linux-kernel - Re: [PATCH] mm/vmalloc: Use batched page requests in bulk-allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOMmKo1FMNz048zV@casper.infradead.org>
Date:   Mon, 5 Jul 2021 16:32:58 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        Mel Gorman <mgorman@...e.de>,
        Christoph Hellwig <hch@...radead.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Hillf Danton <hdanton@...a.com>,
        Michal Hocko <mhocko@...e.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] mm/vmalloc: Use batched page requests in bulk-allocator

On Mon, Jul 05, 2021 at 04:55:47PM +0200, Uladzislau Rezki (Sony) wrote:
> +			if (gfpflags_allow_blocking(gfp))
> +				cond_resched();

How does one call vmalloc() with gfp flags that _don't_ allow blocking?
They have to allow a GFP_KERNEL allocation of the page tables.
So I think this should be an unconditional cond_resched().