linux-kernel - Re: [PATCH] net: rtnetlink: Fix rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a00ac67-f5bc-8ff8-3737-ebea83777f87@gmail.com>
Date:   Thu, 8 Jul 2021 10:08:27 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Yajun Deng <yajun.deng@...ux.dev>, davem@...emloft.net,
        kuba@...nel.org, ryazanov.s.a@...il.com, johannes.berg@...el.com,
        avagin@...il.com, vladimir.oltean@....com, cong.wang@...edance.com,
        roopa@...ulusnetworks.com, zhudi21@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: rtnetlink: Fix rtnl_dereference return value is NULL



On 7/8/21 9:37 AM, Yajun Deng wrote:
> rtnl_dereference() may be return NULL in rtnl_unregister(),
> so add this case handling.
> 
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
>  net/core/rtnetlink.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 

I do not see a use case for this.
None of rtnl_unregister() callers check the return value anyway.

Can you elaborate ?

If this was a bug fix, we would need a Fixes: tag.

If this is something you need for an upcoming work, you would need to tag
this for net-next tree.

Thanks.