linux-kernel - RE: [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR11MB28486EDB516440AFB4044932E1199@SN6PR11MB2848.namprd11.prod.outlook.com>
Date:   Thu, 8 Jul 2021 20:20:11 +0000
From:   <Don.Brace@...rochip.com>
To:     <pmenzel@...gen.mpg.de>, <Murthy.Bhat@...rochip.com>
CC:     <Kevin.Barnett@...rochip.com>, <Scott.Teel@...rochip.com>,
        <Justin.Lindley@...rochip.com>, <Scott.Benesh@...rochip.com>,
        <Gerry.Morong@...rochip.com>, <Mahesh.Rajashekhara@...rochip.com>,
        <Mike.McGowen@...rochip.com>, <Balsundar.P@...rochip.com>,
        <joseph.szczypek@....com>, <jeff@...onical.com>,
        <POSWALD@...e.com>, <john.p.donnelly@...cle.com>,
        <mwilck@...e.com>, <linux-kernel@...r.kernel.org>,
        <hch@...radead.org>, <martin.peterson@...cle.com>,
        <jejb@...ux.vnet.ibm.com>, <linux-scsi@...r.kernel.org>
Subject: RE: [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for
 resets

From: Paul Menzel [mailto:pmenzel@...gen.mpg.de] 
Subject: Re: [smartpqi updates PATCH 4/9] smartpqi: add SCSI cmd info for resets

Dear Murthy, dear Don,


Am 06.07.21 um 20:16 schrieb Don Brace:
> From: Murthy Bhat <Murthy.Bhat@...rochip.com>
>
> Report on SCSI command that has triggered the reset.
>   - Also add check for 0 length SCSI commands.

Can you please add an example log message line to the git commit message summary?

Don: Thanks for your review. I added an example.

Kind regards,

Paul


> Reviewed-by: Kevin Barnett <kevin.barnett@...rochip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@...rochip.com>
> Reviewed-by: Scott Benesh <scott.benesh@...rochip.com>
> Reviewed-by: Scott Teel <scott.teel@...rochip.com>
> Signed-off-by: Murthy Bhat <Murthy.Bhat@...rochip.com>
> Signed-off-by: Don Brace <don.brace@...rochip.com>
> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c 
> b/drivers/scsi/smartpqi/smartpqi_init.c
> index 5ce1c41a758d..c2ddb66b5c2d 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -6033,8 +6033,10 @@ static int pqi_eh_device_reset_handler(struct scsi_cmnd *scmd)
>       mutex_lock(&ctrl_info->lun_reset_mutex);
>
>       dev_err(&ctrl_info->pci_dev->dev,
> -             "resetting scsi %d:%d:%d:%d\n",
> -             shost->host_no, device->bus, device->target, device->lun);
> +             "resetting scsi %d:%d:%d:%d due to cmd 0x%02x\n",
> +             shost->host_no,
> +             device->bus, device->target, device->lun,
> +             scmd->cmd_len > 0 ? scmd->cmnd[0] : 0xff);
>
>       pqi_check_ctrl_health(ctrl_info);
>       if (pqi_ctrl_offline(ctrl_info))
>