linux-kernel - RE: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jul 2021 21:17:53 +0000
From:   <Don.Brace@...rochip.com>
To:     <pmenzel@...gen.mpg.de>, <Mike.McGowen@...rochip.com>
CC:     <Kevin.Barnett@...rochip.com>, <Scott.Teel@...rochip.com>,
        <Justin.Lindley@...rochip.com>, <Scott.Benesh@...rochip.com>,
        <Gerry.Morong@...rochip.com>, <Mahesh.Rajashekhara@...rochip.com>,
        <Murthy.Bhat@...rochip.com>, <Balsundar.P@...rochip.com>,
        <joseph.szczypek@....com>, <jeff@...onical.com>,
        <POSWALD@...e.com>, <john.p.donnelly@...cle.com>,
        <mwilck@...e.com>, <linux-kernel@...r.kernel.org>,
        <hch@...radead.org>, <martin.peterson@...cle.com>,
        <jejb@...ux.vnet.ibm.com>, <linux-scsi@...r.kernel.org>
Subject: RE: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null
 structure member

From: Paul Menzel [mailto:pmenzel@...gen.mpg.de] 
Subject: Re: [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member

Dear Don, dear Mike,


Am 06.07.21 um 20:16 schrieb Don Brace:
> From: Mike McGowen <mike.mcgowen@...rochip.com>
>
> Correct driver's ISR accessing a data structure member that has not 
> been fully initialized during driver init.

Does that crash the Linux kernel?
Don: 
No. I updated the title and description to reflect this. It resulted in some brief access to uninitialized members.
This was found during some internal testing, no bugs were ever filed for this change.
 
Thanks for your review.

>    - The pqi queue groups can be null when an interrupt fires.

If it fixes a crash(?), please add a Fixes: tag so it can be backported to the stable series.



Kind regards,

Paul