linux-kernel - Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YOgbp79NQeN6K1e1@kroah.com>
Date:   Fri, 9 Jul 2021 11:49:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Nava kishore Manne <navam@...inx.com>
Cc:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Michal Simek <michals@...inx.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        "arnd@...db.de" <arnd@...db.de>, Rajan Vaja <RAJANV@...inx.com>,
        Amit Sunil Dhamne <amitsuni@...x.xilinx.com>,
        Tejas Patel <tejasp@...x.xilinx.com>,
        "zou_wei@...wei.com" <zou_wei@...wei.com>,
        Sai Krishna Potthuri <lakshmis@...inx.com>,
        Ravi Patel <ravipate@...x.xilinx.com>,
        "iwamatsu@...auri.org" <iwamatsu@...auri.org>,
        Jiaying Liang <jliang@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        git <git@...inx.com>,
        "chinnikishore369@...il.com" <chinnikishore369@...il.com>
Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
 support

On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote:
> Hi Greg,
> 
> 	Thanks for providing the review comments.
> Please find my response inline.
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: Wednesday, June 9, 2021 3:25 PM
> > To: Nava kishore Manne <navam@...inx.com>
> > Cc: robh+dt@...nel.org; Michal Simek <michals@...inx.com>;
> > mdf@...nel.org; trix@...hat.com; arnd@...db.de; Rajan Vaja
> > <RAJANV@...inx.com>; Amit Sunil Dhamne <amitsuni@...x.xilinx.com>;
> > Tejas Patel <tejasp@...x.xilinx.com>; zou_wei@...wei.com; Sai Krishna
> > Potthuri <lakshmis@...inx.com>; Ravi Patel <RAVIPATE@...inx.com>;
> > iwamatsu@...auri.org; Jiaying Liang <jliang@...inx.com>;
> > devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> > kernel@...r.kernel.org; linux-fpga@...r.kernel.org; git <git@...inx.com>;
> > chinnikishore369@...il.com
> > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
> > support
> > 
> > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > > This patch adds user encrypted key load API to support User key
> > > encrypted images loading use cases from Linux.
> > 
> > What is "user key encrypted images"?  Do we need more documentation
> > here for what this is and how to use it?
> > 
> 
> Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode.
> User can supply a 128-bit Initial Vector and 256-bit key(user key).

Please provide the needed information in the changelog comment.

> For more info please refer here: 
> https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf 

External links always grow stale.

thanks,

greg k-h