linux-kernel - Re: [PATCH] perf/x86/intel: Apply early ACK for small core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOgbs6i9Q/EoGDj9@hirez.programming.kicks-ass.net>
Date:   Fri, 9 Jul 2021 11:49:39 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     kan.liang@...ux.intel.com
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Apply early ACK for small core

On Thu, Jul 08, 2021 at 12:54:33PM -0700, kan.liang@...ux.intel.com wrote:
> @@ -2921,7 +2920,7 @@ static int intel_pmu_handle_irq(struct pt_regs *regs)
>  	 * No known reason to not always do late ACK,
>  	 * but just in case do it opt-in.
>  	 */

^^^ comment is now seriously out of date. Can you please update it?

> -	if (!x86_pmu.late_ack)
> +	if (!late_ack)
>  		apic_write(APIC_LVTPC, APIC_DM_NMI);