linux-kernel - Re: [PATCH V2 1/2] driver core: Add ability to delete device links of unregistered devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOgdBGBEYNndLLwa@kroah.com>
Date:   Fri, 9 Jul 2021 11:55:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Saravana Kannan <saravanak@...gle.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org, Avri Altman <avri.altman@....com>,
        Bean Huo <huobean@...il.com>, Can Guo <cang@...eaurora.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/2] driver core: Add ability to delete device links
 of unregistered devices

On Fri, Jul 09, 2021 at 09:43:40AM +0300, Adrian Hunter wrote:
> Managed device links are deleted by device_del(). However it is possible to
> add a device link to a consumer before device_add(), and then discover an
> error prevents the device from being used. In that case normally references
> to the device would be dropped and the device would be deleted. However the
> device link holds a reference to the device, so the device link and device
> remain indefinitely.

Why are you not just manually removing the link you just created?  You
manually added it, you know something failed so you need to clean up, so
why not clean this up too?

thanks,

greg k-h