linux-kernel - Re: [PATCH 1/5] mm/vmscan: put the redirtied MADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YO1dGvcTLaRJplRQ@dhcp22.suse.cz>
Date:   Tue, 13 Jul 2021 11:30:02 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, hannes@...xchg.org, vbabka@...e.cz,
        axboe@...nel.dk, iamjoonsoo.kim@....com, alexs@...nel.org,
        apopple@...dia.com, willy@...radead.org, minchan@...nel.org,
        david@...hat.com, shli@...com, hillf.zj@...baba-inc.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] mm/vmscan: put the redirtied MADV_FREE pages back to
 anonymous LRU list

On Mon 12-07-21 19:03:39, Miaohe Lin wrote:
> On 2021/7/12 15:22, Michal Hocko wrote:
> > On Sat 10-07-21 18:03:25, Miaohe Lin wrote:
> >> If the MADV_FREE pages are redirtied before they could be reclaimed, put
> >> the pages back to anonymous LRU list by setting SwapBacked flag and the
> >> pages will be reclaimed in normal swapout way. Otherwise MADV_FREE pages
> >> won't be reclaimed as expected.
> > 
> > Could you describe problem which you are trying to address? What does it
> > mean that pages won't be reclaimed as expected?
> > 
> 
> In fact, this is not a bug and harmless.

Fixes tag is then misleading and the changelog should be more clear
about this as well.

> But it looks buggy as it didn't perform
> the expected ops from code view. Lazyfree (MADV_FREE) pages are clean anonymous
> pages. They have SwapBacked flag cleared to distinguish normal anonymous pages.

yes.

> When the MADV_FREE pages are redirtied before they could be reclaimed, the pages
> should be put back to anonymous LRU list by setting SwapBacked flag, thus the
> pages will be reclaimed in normal swapout way.

Agreed. But the question is why this needs an explicit handling here
when we already do handle this case when trying to unmap the page.
Please make sure to document the behavior you are observing, why it is
not desirable.

> Many thanks for review and reply.
> 
> > Also why is SetPageSwapBacked in shrink_page_list insufficient?

Sorry I meant to say try_to_unmap path here

> >> Fixes: 802a3a92ad7a ("mm: reclaim MADV_FREE pages")
> >> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> >> ---
> >>  mm/vmscan.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/mm/vmscan.c b/mm/vmscan.c
> >> index a7602f71ec04..6483fe0e2065 100644
> >> --- a/mm/vmscan.c
> >> +++ b/mm/vmscan.c
> >> @@ -1628,6 +1628,7 @@ static unsigned int shrink_page_list(struct list_head *page_list,
> >>  			if (!page_ref_freeze(page, 1))
> >>  				goto keep_locked;
> >>  			if (PageDirty(page)) {
> >> +				SetPageSwapBacked(page);
> >>  				page_ref_unfreeze(page, 1);
> >>  				goto keep_locked;
> >>  			}
> >> -- 
> >> 2.23.0
> > 

-- 
Michal Hocko
SUSE Labs