linux-kernel - Re: [PATCH 5/5] mm/vmscan: fix misleading comment in isolate_lru

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ecacfca-4aba-b2c2-bc61-56a7a5d0fb2b@huawei.com>
Date:   Tue, 13 Jul 2021 20:50:38 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Michal Hocko <mhocko@...e.com>
CC:     <akpm@...ux-foundation.org>, <hannes@...xchg.org>,
        <vbabka@...e.cz>, <axboe@...nel.dk>, <iamjoonsoo.kim@....com>,
        <alexs@...nel.org>, <apopple@...dia.com>, <willy@...radead.org>,
        <minchan@...nel.org>, <david@...hat.com>, <shli@...com>,
        <hillf.zj@...baba-inc.com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] mm/vmscan: fix misleading comment in
 isolate_lru_pages()

On 2021/7/13 17:32, Michal Hocko wrote:
> On Mon 12-07-21 19:16:47, Miaohe Lin wrote:
>> On 2021/7/12 15:28, Michal Hocko wrote:
>>> On Sat 10-07-21 18:03:29, Miaohe Lin wrote:
>>>> We couldn't know whether the page is being freed elsewhere until we failed
>>>> to increase the page count.
>>>
>>> This is moving a hard to understand comment from one place to another.
>>
>> If get_page_unless_zero failed, the page could have been freed elsewhere. I think
>> this looks straightforward but doesn't help a lot. Are you preferring to just
>> remove this comment ?
> 
> Yes the comment in its current form is not really helpful much. Does it
> deserve a single liner to drop it? Likely not on its own without more
> changes in that area.

Sure, I will drop this single patch. And I would send a new patch when I collect enough
misleading/obsolete comments to fix.

Thanks.

>