linux-kernel - Re: [PATCH] cacheinfo: clear cache_leaves(cpu) in free_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae05d599-3470-ec49-f354-79a6421c0d9c@arm.com>
Date:   Wed, 14 Jul 2021 18:13:23 +0100
From:   James Morse <james.morse@....com>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     linux-kernel@...r.kernel.org, bobo.shaobowang@...wei.com
Subject: Re: [PATCH] cacheinfo: clear cache_leaves(cpu) in
 free_cache_attributes()

Hi Xiongfeng,

(CC: dropping Greg, Rafael and Sudeep as this isn't likely to be of interest to them)

On 14/07/2021 03:10, Xiongfeng Wang wrote:
> On 2021/7/14 1:38, James Morse wrote:
>> On 13/07/2021 14:26, Sudeep Holla wrote:
>>> On Tue, Jul 13, 2021 at 08:46:19PM +0800, Xiongfeng Wang wrote:
>>>> Actually, it's our own code that crashed. My colleague Shaobo(CCed) tried to add
>>
>> Seems to have dropped off the CC list.
> 
> Yes. I don't know why I didn't CC him success. CCed again.
> 
>>
>>>> MPAM support on ARM64.
>>
>> Do you want me to CC either of you on the series that refactor the resctrl code? This is
>> the bit that needs doing to get MPAM working upstream
> 
> It would be nice if you could CC him. His email address is
> bobo.shaobowang@...wei.com. Thanks a lot !

Thanks, I will!

> Below is the (openEuler version) MPAM support code he wrote based on your
> private version in linux-arm.org repo:
> https://gitee.com/openeuler/kernel/tree/openEuler-1.0-LTS/arch/arm64/kernel/mpam
> It would be appreciated if you could give some advice.

(I've not looked in any detail, but)

Beware duplicating any of the code that is involved in the user facing ABI. This will
create subtle differences between the behaviour of x86 and arm64 for the resctrl
filesystem. This must not be allowed to happen as its bad for user-space.

> console display:
> [root@...alhost ~]# mount -t resctrl resctrl /sys/fs/resctrl/ -o
> cdpl3,caPbm,mbHdl,mbMax
> [root@...alhost ~]# cd /sys/fs/resctrl/
> [root@...alhost resctrl]# cat schemata
> L3CODEPBM:0=7fff;1=7fff;2=7fff;3=7fff
> L3DATAPBM:0=7fff;1=7fff;2=7fff;3=7fff
> MBHDL:0=1;1=1;2=1;3=1
> MBMAX:0=100;1=100;2=100;3=100

Please don't create new 'things' visible to user-space.
You should not need to change user-space software.

The whole point of using resctrl is so that existing user-space software works, and linux
has one behaviour across all architectures. (It doesn't matter if the names are wrong,
only the behaviour matters)

If new schema are needed, we should wait until we've got the existing resctrl stuff
working upstream, then discuss it with the x86 folk, as any new schema must be possible to
support on x86 too.

Thanks,

James