linux-kernel - Re: [PATCH AUTOSEL 4.19 35/55] net: fix mistake path for netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210715084524.GA29090@amd>
Date:   Thu, 15 Jul 2021 10:45:24 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jian Shen <shenjian15@...wei.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH AUTOSEL 4.19 35/55] net: fix mistake path for
 netdev_features_strings

Hi!

> From: Jian Shen <shenjian15@...wei.com>
> 
> [ Upstream commit 2d8ea148e553e1dd4e80a87741abdfb229e2b323 ]
> 
> Th_strings arrays netdev_features_strings, tunable_strings, and
> phy_tunable_strings has been moved to file net/ethtool/common.c.
> So fixes the comment.

This patch is incorrect for 4.19, as is still uses original filename,
not "net/ethtool/common.c".

[Plus it really should not be suitable for any stable release according
to our rules.]

Best regards,
								Pavel

> +++ b/include/linux/netdev_features.h
> @@ -88,7 +88,7 @@ enum {
>  
>  	/*
>  	 * Add your fresh new feature above and remember to update
> -	 * netdev_features_strings[] in net/core/ethtool.c and maybe
> +	 * netdev_features_strings[] in net/ethtool/common.c and maybe
>  	 * some feature mask #defines below. Please also describe it
>  	 * in Documentation/networking/netdev-features.txt.
>  	 */

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)