linux-kernel - RE: [PATCH RFC 07/13] iomap: simplify iomap_swapfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB4376391DC23C94DF22E72B9CF7119@AM6PR08MB4376.eurprd08.prod.outlook.com>
Date:   Fri, 16 Jul 2021 06:17:29 +0000
From:   Justin He <Justin.He@....com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        nd <nd@....com>, "Darrick J. Wong" <djwong@...nel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with
 '%pD' specifier

Hi Christoph

> -----Original Message-----
> From: Christoph Hellwig <hch@...radead.org>
> Sent: Friday, July 16, 2021 2:11 PM
> To: Justin He <Justin.He@....com>
> Cc: linux-kernel@...r.kernel.org; Linus Torvalds <torvalds@...ux-
> foundation.org>; Christoph Hellwig <hch@...radead.org>; nd <nd@....com>;
> Darrick J. Wong <djwong@...nel.org>; linux-xfs@...r.kernel.org; linux-
> fsdevel@...r.kernel.org
> Subject: Re: [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with
> '%pD' specifier
> 
> On Thu, Jul 15, 2021 at 11:15:27AM +0800, Jia He wrote:
> > After the behavior of '%pD' is change to print the full path of file,
> > iomap_swapfile_fail() can be simplified.
> >
> > Given the space with proper length would be allocated in vprintk_store(),
> > the kmalloc() is not required any more.
> >
> > Besides, the previous number postfix of '%pD' in format string is
> > pointless.
> 
> This also touched iomap_dio_actor, but the commit og only mentions
> iomap_swapfile_fail.
Okay, I will refine the msg in next version.
Thanks


--
Cheers,
Justin (Jia He)