linux-kernel - Re: [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51d24b1a-7146-bacd-87ee-4be487c455d8@linux.dev>
Date:   Fri, 16 Jul 2021 17:38:25 +0800
From:   Guoqing Jiang <guoqing.jiang@...ux.dev>
To:     Jia He <justin.he@....com>, linux-kernel@...r.kernel.org
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@...radead.org>, nd@....com,
        Song Liu <song@...nel.org>, linux-raid@...r.kernel.org
Subject: Re: [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD'
 specifier



On 7/15/21 11:15 AM, Jia He wrote:
> After the behavior of '%pD' is changed to print the full path of file,
> the log printing can be simplified.
>
> Given the space with proper length would be allocated in vprintk_store(),
> it is worthy of dropping kmalloc()/kfree() to avoid additional space
> allocation. The error case is well handled in d_path_unsafe(), the error
> string would be copied in '%pD' buffer, no need to additionally handle
> IS_ERR().
>
> Cc: Song Liu <song@...nel.org>
> Cc: linux-raid@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Jia He <justin.he@....com>
> ---
>   drivers/md/md-bitmap.c | 13 ++-----------
>   1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index e29c6298ef5c..a82f1c2ef83c 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -862,21 +862,12 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store)
>    */
>   static void md_bitmap_file_kick(struct bitmap *bitmap)
>   {
> -	char *path, *ptr = NULL;
> -
>   	if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) {
>   		md_bitmap_update_sb(bitmap);
>   
>   		if (bitmap->storage.file) {
> -			path = kmalloc(PAGE_SIZE, GFP_KERNEL);
> -			if (path)
> -				ptr = file_path(bitmap->storage.file,
> -					     path, PAGE_SIZE);
> -
> -			pr_warn("%s: kicking failed bitmap file %s from array!\n",
> -				bmname(bitmap), IS_ERR(ptr) ? "" : ptr);
> -
> -			kfree(path);
> +			pr_warn("%s: kicking failed bitmap file %pD from array!\n",
> +				bmname(bitmap), bitmap->storage.file);
>   		} else
>   			pr_warn("%s: disabling internal bitmap due to errors\n",
>   				bmname(bitmap));

Looks good,  Acked-by: Guoqing Jiang <guoqing.jiang@...ux.dev>

Thanks,
Guoqing